Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Temporarily modify single table demo data link #121

Merged
merged 3 commits into from
Jan 20, 2024

Conversation

MooooCat
Copy link
Contributor

Description

Due to datahub.io issues, all current pytest unit tests fail because they cannot download the demo data.

Currently, we modify the link to the data set to temporarily solve this problem.

Motivation and Context

How has this been tested?

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@hitsz-ids hitsz-ids deleted a comment from sweep-ai bot Jan 20, 2024
@hitsz-ids hitsz-ids deleted a comment from sweep-ai bot Jan 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd70515) 78.58% compared to head (8d88aa5) 78.94%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   78.58%   78.94%   +0.36%     
==========================================
  Files          64       64              
  Lines        2764     2764              
==========================================
+ Hits         2172     2182      +10     
+ Misses        592      582      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MooooCat MooooCat marked this pull request as ready for review January 20, 2024 11:01
@MooooCat MooooCat merged commit 1bbf3f5 into main Jan 20, 2024
11 checks passed
@MooooCat MooooCat deleted the bugfix-demo-data-download branch January 31, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants