Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix metric mutual information #118

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Conversation

Z712023
Copy link
Collaborator

@Z712023 Z712023 commented Jan 18, 2024

Description

  1. correct the test of MI similarity
  2. add datetime test

Motivation and Context

  1. test is wrong
  2. test coverage is not full.

How has this been tested?

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@hitsz-ids hitsz-ids deleted a comment from sweep-ai bot Jan 18, 2024
@hitsz-ids hitsz-ids deleted a comment from sweep-ai bot Jan 18, 2024
@hitsz-ids hitsz-ids deleted a comment from sweep-ai bot Jan 18, 2024
@hitsz-ids hitsz-ids deleted a comment from sweep-ai bot Jan 18, 2024
@Z712023 Z712023 requested a review from MooooCat January 18, 2024 10:29
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd70515) 78.58% compared to head (9d1b93c) 78.94%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   78.58%   78.94%   +0.36%     
==========================================
  Files          64       64              
  Lines        2764     2764              
==========================================
+ Hits         2172     2182      +10     
+ Misses        592      582      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MooooCat MooooCat merged commit 9ac9988 into main Jan 18, 2024
11 checks passed
@MooooCat MooooCat deleted the bugfix-metric-mutual_information branch January 18, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants