Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Regex Inspector and Email Inspector example. #115

Merged
merged 37 commits into from
Jan 29, 2024

Conversation

MooooCat
Copy link
Contributor

Description

Motivation and Context

How has this been tested?

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@MooooCat MooooCat linked an issue Jan 18, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fc5201e) 79.13% compared to head (378d0a9) 80.00%.

Files Patch % Lines
sdgx/data_models/inspectors/regex.py 98.27% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   79.13%   80.00%   +0.87%     
==========================================
  Files          64       66       +2     
  Lines        2823     2926     +103     
==========================================
+ Hits         2234     2341     +107     
+ Misses        589      585       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sweep-ai bot and others added 3 commits January 18, 2024 17:15
* feat: Add new_system.rst to document the design of

* feat: Updated LICENSE

* feat: Updated docs/source/design/motivation.rst

* feat: Updated docs/source/developer_guides/extensi

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: sweep-ai[bot] <128439645+sweep-ai[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@hitsz-ids hitsz-ids deleted a comment from sweep-ai bot Jan 18, 2024
LICENSE Outdated Show resolved Hide resolved
@MooooCat MooooCat marked this pull request as ready for review January 24, 2024 05:15
@Wh1isper
Copy link
Collaborator

Can we test all default Inspector in https://github.com/hitsz-ids/synthetic-data-generator/blob/main/tests/manager/test_inspector_manager.py to verify that the default behaviour is normal and to ensure minimum availability.

@MooooCat
Copy link
Contributor Author

Can we test all default Inspector in https://github.com/hitsz-ids/synthetic-data-generator/blob/main/tests/manager/test_inspector_manager.py to verify that the default behaviour is normal and to ensure minimum availability.

Ah, using manager is a good idea. (妙啊)

@MooooCat MooooCat merged commit c358110 into main Jan 29, 2024
11 checks passed
@MooooCat MooooCat deleted the feature-regex-inspector branch January 29, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Good first issue | Feature] Add Regex Inspector
4 participants