Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mutual information metric #101

Merged
merged 64 commits into from
Jan 16, 2024
Merged

Conversation

MooooCat
Copy link
Contributor

Description

Motivation and Context

How has this been tested?

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (d29a2a0) 78.99% compared to head (8020a9a) 78.58%.

Files Patch % Lines
sdgx/metrics/pair_column/base.py 45.45% 18 Missing ⚠️
sdgx/metrics/pair_column/mi_sim.py 82.60% 8 Missing ⚠️
sdgx/utils.py 40.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   78.99%   78.58%   -0.42%     
==========================================
  Files          62       64       +2     
  Lines        2680     2764      +84     
==========================================
+ Hits         2117     2172      +55     
- Misses        563      592      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/metrics/test_MISim.py Outdated Show resolved Hide resolved
pre-commit-ci bot and others added 25 commits January 16, 2024 08:36
…ids/synthetic-data-generator into feature-metric-mutual_information
@MooooCat MooooCat marked this pull request as ready for review January 16, 2024 13:33
@MooooCat MooooCat enabled auto-merge (squash) January 16, 2024 13:39
@MooooCat MooooCat merged commit dae869e into main Jan 16, 2024
11 checks passed
@MooooCat MooooCat deleted the feature-metric-mutual_information branch January 16, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Good first issue | Feature] Multi-Table Metric: Mutual Information Similarity
3 participants