Add None value handling for JSONObject builder #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
beagold
requested changes
Aug 28, 2024
| @@ -0,0 +1 @@ | |||
| Add `None` check for every put function in `JSONObjectBuilder` | |||
There was a problem hiding this comment.
No need for this changelog fragment, this change is purely internal
beagold
added
the
skip-fragment-check
Co-authored-by: beagold <86345081+beagold@users.noreply.github.com> Signed-off-by: Blaze <88249929+syncblaze@users.noreply.github.com>
Co-authored-by: beagold <86345081+beagold@users.noreply.github.com> Signed-off-by: Blaze <88249929+syncblaze@users.noreply.github.com>
Co-authored-by: beagold <86345081+beagold@users.noreply.github.com> Signed-off-by: Blaze <88249929+syncblaze@users.noreply.github.com>
i can do that no problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If whe build a json object, the value should not be added to the json if its undefined type, but if its None it should just be added as None. These None checks were performed in the rest functions etc which used the JSON Object builder until now, but it makes far more sense to put this None check into the json builder.
Checklist
noxand all the pipelines have passed.Related issues