enh(nsis) improve highlighter rules and tests #3822
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have identified several highlighting issues and reported them #3821. In my memory, these inconsistencies did not exist in earlier versions, but I could be wrong.
This PR adds some tests to identify the problems Obviously, the highlighting rules need to be updated before a merge, so I consider this PR work in progress.
Specifically, I tried adding block-keywords such as
!macro
/!macroend
to the beginKeywords block, but this did not solve the problem. Could the exclamation mark, as a non-word character cause this problem? Also, defining!macroend
before the!macro
keyword did not have an effect. I'm looking for some direction on how to tackle these issues!Changes
Todo
Checklist
CHANGES.md