-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(css): handle css variables syntax #3239
Conversation
A visual snap is alwyas nice with PRs like this. |
@joshgoebel here it is how it looks like on base16/nord theme. |
76da024
to
b2cfa28
Compare
Theme maintainers: Here is a case where we're increasing the semantic density of our highlighting, but at the same time perhaps making existing theme behavior worse. I have a suspicion many/some themes only think about Just sticking with I could also see many themes wanting to just merge these two styles (in the case of CSS), yes I hesitate to do that at the grammar level since I always try to be as accurate as possible when it comes to scopes - and then let themes decide HOW to highlight those scope. So perhaps the semantic difference here between attributes and custom attributes (specifically w.r.t. CSS) just doesn't matter? Thoughts? CC @highlightjs/theme-maintainers @highlightjs/core |
@joshgoebel any updates on this? Is this currently blocked until we get an answer on your last question? |
I was hoping for some thoughts, yes. Eventually if there is nothing this'll probably merge as-is... I don't usually get in a rush until I have a new release in sight. I need to go figure out when 11.1 will be. |
Thanks for your swift reply. |
83e5a7d
to
90c7e9f
Compare
90c7e9f
to
4f759a5
Compare
This PR addresses the #3237 so that CSS variables syntax is properly highlighted.
Changes
src/languages/css.js
definitionChecklist
CHANGES.md