-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh(java) support functions with nested template types #3074
Conversation
34b5b91
to
e9ffc4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @returns {string}`` | ||
*/ | ||
function recurRegex(re, substitution, depth) { | ||
if (depth === -1) return ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (depth === -1) return ""; | |
if (depth < 0) return ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is an improvement. I'd rather be precise.
It accounts for the examples I was given. If your example is common then we can bump the # slightly but there is no need for it to be higher than it should be. Bump it to 2? |
afa3c49
to
ca853fa
Compare
Can’t speak for everyone but I see deeply nested types all the time in my work. |
Resolves #2641.
Changes
Allows Java template types for functions to be recursive a single level:
IE (Token within List):
Checklist
CHANGES.md