(CPP) Declaring multiple variables with parentheticals treated as invalid

[edemaine]

Declaring multiple variadic variables with initializers generates an invalid error.

Example code (which Github also seems to highlight inconsistently):

vector<int> e(n), depth(n);

Highlight.js 10.4.0 and 10.7.2 generate an Illegal lexeme "," for mode "function" error. Direct reproduction:

require('highlight.js/lib/core').highlight('vector<int> e(n), depth(n);', {language: 'cpp'})

Issue #2917 seems related, and perhaps this has a similarly easy fix.

On the plus side, I just learned about the ignoreIllegals setting, so I'll probably just switch to using that in my context.

[joshgoebel]

which Github also seems to highlight inconsistently)

Probably because it's impossible to pattern match and know for sure WHAT it is. The first part is probably matching as a function then it doesn't know what to do with the rest.

It's not really a function at all, though I'm not sure we'd be able to tell otherwise. The simple fix here might be to just add , to the end rule of function causing it to end as soon as it see the , - which would probably result in behavior similar to what GitHub is doing....

[joshgoebel]

I just learned about the ignoreIllegals setting, so I'll probably just switch to using that in my context.

You probably should. See the thread I just posted. I think the use cases for illegals (outside our internal use for auto-detection) are pretty slim.

[joshgoebel]

The simple fix here might be...

@edemaine Want to make an attempt at a PR?

[edemaine]

Sure. What branch should I be diffing against? master doesn't build (because of #3094). Oops, sorry, I was on an old fork.