Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

John/hig-1053-strictprivacy-mode-is-injecting-random #52

Merged
merged 2 commits into from
Sep 23, 2021
Merged

John/hig-1053-strictprivacy-mode-is-injecting-random #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48ab373
Bump package version
Sep 23, 2021
2c67e9a
Fix non-printing whitespaces being rendered with privacy mode
Sep 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@highlight-run/rrweb",
"version": "0.12.11",
"version": "0.12.12",
"description": "record and replay the web",
"scripts": {
"test": "npm run bundle:browser && cross-env TS_NODE_CACHE=false TS_NODE_FILES=true mocha -r ts-node/register -r ignore-styles -r jsdom-global/register test/**.test.ts",
Expand Down
7 changes: 6 additions & 1 deletion src/snapshot/snapshot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,12 @@ function serializeNode(
'BODY',
'NOSCRIPT',
]);
if (!IGNORE_TAG_NAMES.has(parentTagName)) {
if (!IGNORE_TAG_NAMES.has(parentTagName) && textContent) {
// We remove non-printing characters.
// For example: '‌' is a character that isn't shown visibly or takes up layout space on the screen. However if you take the length of the string, it's counted as 1.
// For example: "‌1"'s length is 2 but visually it's only taking up 1 character width.
// If we don't filter does out, our string obfuscation could have more characters than what was originally presented.
textContent = textContent.replace(/[^ -~]+/g, '');
textContent =
textContent
?.split(' ')
Expand Down