Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't record value attribute on password inputs #32

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Don't record value attribute on password inputs #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c5077f
Don't record password
Mar 31, 2021
e447572
v0.10.2
Mar 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@highlight-run/rrweb",
"version": "0.10.1",
"version": "0.10.2",
"description": "record and replay the web",
"scripts": {
"test": "npm run bundle:browser && cross-env TS_NODE_CACHE=false TS_NODE_FILES=true mocha -r ts-node/register test/**/*.test.ts",
Expand Down
3 changes: 2 additions & 1 deletion src/snapshot/snapshot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,8 @@ function serializeNode(
) {
attributes.value =
maskInputOptions[attributes.type as keyof MaskInputOptions] ||
maskInputOptions[tagName as keyof MaskInputOptions]
maskInputOptions[tagName as keyof MaskInputOptions] ||
attributes.type === 'password'
? '*'.repeat(value.length)
: value;
} else if ((n as HTMLInputElement).checked) {
Expand Down