Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider allevents for inactivity #31

Merged
merged 3 commits into from
Mar 30, 2021
Merged

Consider allevents for inactivity #31

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98e2f33
Consider allevents for inactivity
eightants Mar 30, 2021
87ac0c7
Remove log
eightants Mar 30, 2021
1f0013d
skip inactive
eightants Mar 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@highlight-run/rrweb",
"version": "0.10.0",
"version": "0.10.1",
"description": "record and replay the web",
"scripts": {
"test": "npm run bundle:browser && cross-env TS_NODE_CACHE=false TS_NODE_FILES=true mocha -r ts-node/register test/**/*.test.ts",
Expand Down
12 changes: 5 additions & 7 deletions src/replay/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,16 +292,14 @@ export class Replayer {
// Preprocessing to get all active/inactive segments in a session
const allIntervals: Array<SessionInterval> = [];
const metadata = this.getMetaData();
const userInteractionEvents = [
const allEvents = [
{ timestamp: metadata.startTime },
...this.service.state.context.events.filter((ev) =>
this.isUserInteraction(ev),
),
...this.service.state.context.events,
{ timestamp: metadata.endTime },
];
for (let i = 1; i < userInteractionEvents.length; i++) {
const currentInterval = userInteractionEvents[i - 1];
const _event = userInteractionEvents[i];
for (let i = 1; i < allEvents.length; i++) {
const currentInterval = allEvents[i - 1];
const _event = allEvents[i];
if (
_event.timestamp! - currentInterval.timestamp! >
SKIP_TIME_THRESHOLD
Expand Down