Add nested scroll support (#31)

highlight · Jul 25, 2020 · f7d43f5 · f7d43f5
1 parent 785ff39
commit f7d43f5
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 4 deletions.
diff --git a/src/rebuild.ts b/src/rebuild.ts
@@ -102,7 +102,7 @@ function buildNode(
           continue;
         }
         let value = n.attributes[name];
-        value = typeof value === 'boolean' ? '' : value;
+        value = typeof value === 'boolean' || typeof value === 'number' ? '' : value;
         // attribute names start with rr_ are internal attributes added by rrweb
         if (!name.startsWith('rr_')) {
           const isTextarea = tagName === 'textarea' && name === 'value';
@@ -220,6 +220,29 @@ export function buildNodeWithSN(
   return node as INode;
 }
 
+function sideEffects(idNodeMap: idNodeMap) {
+  for(let id in idNodeMap) {
+    const node = idNodeMap[id];
+    const n = node.__sn;
+    if (n.type !== NodeType.Element) {
+      continue;
+    }
+    const el = node as Node as HTMLElement;
+    for(const name in n.attributes) {
+      if (!(n.attributes.hasOwnProperty(name) && name.startsWith('rr_'))) {
+        continue;
+      }
+      const value = n.attributes[name];
+      if (name === 'rr_scrollLeft') {
+        el.scrollLeft = value as number;
+      }
+      if (name === 'rr_scrollTop') {
+        el.scrollTop = value as number;
+      }
+    }
+  }
+}
+
 function rebuild(
   n: serializedNodeWithId,
   doc: Document,
@@ -229,7 +252,9 @@ function rebuild(
   HACK_CSS: boolean = true,
 ): [Node | null, idNodeMap] {
   const idNodeMap: idNodeMap = {};
-  return [buildNodeWithSN(n, doc, idNodeMap, false, HACK_CSS), idNodeMap];
+  const node = buildNodeWithSN(n, doc, idNodeMap, false, HACK_CSS);
+  sideEffects(idNodeMap);
+  return [node, idNodeMap];
 }
 
 export default rebuild;
diff --git a/src/snapshot.ts b/src/snapshot.ts
@@ -269,6 +269,13 @@ function serializeNode(
           ? 'paused'
           : 'played';
       }
+      // scroll
+      if ((n as HTMLElement).scrollLeft) {
+        attributes.rr_scrollLeft = (n as HTMLElement).scrollLeft;
+      }
+      if ((n as HTMLElement).scrollTop) {
+        attributes.rr_scrollTop = (n as HTMLElement).scrollTop;
+      }
       if (needBlock) {
         const { width, height } = (n as HTMLElement).getBoundingClientRect();
         attributes.rr_width = `${width}px`;

diff --git a/src/types.ts b/src/types.ts
@@ -20,7 +20,7 @@ export type documentTypeNode = {
 };
 
 export type attributes = {
-  [key: string]: string | boolean;
+  [key: string]: string | number | boolean;
 };
 export type elementNode = {
   type: NodeType.Element;

diff --git a/typings/types.d.ts b/typings/types.d.ts
@@ -17,7 +17,7 @@ export declare type documentTypeNode = {
     systemId: string;
 };
 export declare type attributes = {
-    [key: string]: string | boolean;
+    [key: string]: string | number | boolean;
 };
 export declare type elementNode = {
     type: NodeType.Element;