Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the Logical Type Time millisecond to Avro #417

Merged
merged 3 commits into from
Mar 16, 2021

Conversation

IsabelDuran
Copy link
Contributor

I added the Logical type TTimeMillis to represent Avro's Time (millisecond precision) and added it to the tests.

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #417 (2315258) into master (6aecbd2) will decrease coverage by 0.05%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
- Coverage   85.18%   85.13%   -0.06%     
==========================================
  Files          29       29              
  Lines        1951     1957       +6     
  Branches       27       27              
==========================================
+ Hits         1662     1666       +4     
- Misses        289      291       +2     
Impacted Files Coverage Δ
...in/scala/higherkindness/skeuomorph/mu/schema.scala 65.33% <ø> (+1.33%) ⬆️
.../scala/higherkindness/skeuomorph/avro/schema.scala 61.87% <25.00%> (-1.10%) ⬇️
...scala/higherkindness/skeuomorph/mu/Transform.scala 93.47% <100.00%> (+0.14%) ⬆️
...n/scala/higherkindness/skeuomorph/mu/codegen.scala 91.91% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aecbd2...7a850c5. Read the comment docs.

@fedefernandez fedefernandez added breaking-change A breaking change that needs to be treated with consideration enhancement New feature or request labels Mar 12, 2021
Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@franciscodr franciscodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @IsabelDuran!

@franciscodr franciscodr merged commit 11d60ec into master Mar 16, 2021
@franciscodr franciscodr deleted the time_millis_update branch March 16, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A breaking change that needs to be treated with consideration enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants