Remove @message annotation from generated case classes
#219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This annotation was only used for IDL generation, which we don't do anymore. (also accidentally apply the formatter)
cb372
commented
Jan 27, 2020
| @@ -206,7 +206,7 @@ object codegen { | |||
| nestedCoproducts.traverse(_.as[Stat]) | |||
| ).mapN { | |||
| case (args, prods, coprods) => | |||
| val caseClass = q"@message final case class ${Type.Name(name)}(..$args)" | |||
| val caseClass = q"final case class ${Type.Name(name)}(..$args)" | |||
cb372
commented
Jan 27, 2020
| @@ -95,7 +95,7 @@ class ProtobufProtocolSpec extends Specification with ScalaCheck { | |||
| | | |||
| |object book { | |||
| | | |||
| |@message final case class Book( | |||
| |final case class Book( | |||
There was a problem hiding this comment.
Here is the update to the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This annotation was only used for IDL generation, which we don't do anymore.
(also accidentally apply the formatter)