-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sbt-org-policies plugin #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Paco, however some other setting adjustments need to be made. You might want to use higherkindness/mu-scala#414 as reference
Thanks @juanpedromoreno, I'll do |
8532fe7
to
2043c80
Compare
2043c80
to
b300bde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added a comment. If the answer is no, feel free to merge!
@@ -52,8 +58,8 @@ pgpSecretRing := file(s"$gpgFolder/secring.gpg") | |||
|
|||
// General Settings | |||
lazy val commonSettings = Seq( | |||
organization := "io.frees", | |||
scalaVersion := "2.12.6", | |||
organization := "higherkindness", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be io.higherkindness? If it's what ends up as artifact's org, I think so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have put this value based on the link that @juanpedromoreno posted above. Maybe he could confirm if the value is correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, mu
is set up as organization := "higherkindness"
, and it has been successfully published. I'm guessing higherkindness
would be ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good then! However I think we should double-check how we want to publish all artifacts, if under io.higherkindness or higherkindness, but all shall have the same :). I had a conversation with @andyscott over slack about it, but don't recall the specifics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mu
and droste
are under io.higherkindness
: https://repo1.maven.org/maven2/io/higherkindness/.
@pepegar is that what you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah cool, yeah, I referred to that! My brain is vacationing, sorry ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your comments, guys. I'm gonna merge the pull request. We can go back to this topic once we take a decision for all the projects under higherkindness organization
Once
skeuomorph
has been moved from frees-io to higherkindness organization, does it make sense to start usingsbt-org-policies
instead ofsbt-freestyle
plugin?It closes #4, #5 and #6