Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sbt-org-policies plugin #20

Merged
merged 2 commits into from
Nov 4, 2018
Merged

Conversation

franciscodr
Copy link
Contributor

Once skeuomorph has been moved from frees-io to higherkindness organization, does it make sense to start using sbt-org-policies instead of sbt-freestyle plugin?

It closes #4, #5 and #6

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Paco, however some other setting adjustments need to be made. You might want to use higherkindness/mu-scala#414 as reference

@franciscodr
Copy link
Contributor Author

Thanks @juanpedromoreno, I'll do

Copy link
Member

@pepegar pepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added a comment. If the answer is no, feel free to merge!

@@ -52,8 +58,8 @@ pgpSecretRing := file(s"$gpgFolder/secring.gpg")

// General Settings
lazy val commonSettings = Seq(
organization := "io.frees",
scalaVersion := "2.12.6",
organization := "higherkindness",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be io.higherkindness? If it's what ends up as artifact's org, I think so

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have put this value based on the link that @juanpedromoreno posted above. Maybe he could confirm if the value is correct

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, mu is set up as organization := "higherkindness", and it has been successfully published. I'm guessing higherkindness would be ok

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good then! However I think we should double-check how we want to publish all artifacts, if under io.higherkindness or higherkindness, but all shall have the same :). I had a conversation with @andyscott over slack about it, but don't recall the specifics.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mu and droste are under io.higherkindness: https://repo1.maven.org/maven2/io/higherkindness/.

@pepegar is that what you mean?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah cool, yeah, I referred to that! My brain is vacationing, sorry ;)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your comments, guys. I'm gonna merge the pull request. We can go back to this topic once we take a decision for all the projects under higherkindness organization

@franciscodr franciscodr merged commit 196f743 into master Nov 4, 2018
@franciscodr franciscodr deleted the using-sbt-org-policies-plugin branch November 4, 2018 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependency org.specs2:specs2-core:test
3 participants