Use enumeratum IntEnum for generated enums #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See 47degrees/pbdirect#20 Because it is still a plain old sealed abstract class + case object hierarchy, this change will not affect Avro serialization using avro4s (confirmed with manual testing). Note: This change assumes that enumeratum is on Mu's classpath, which is not yet true. PR on the way to add it as a dependency.
cb372
added a commit
to higherkindness/mu-scala
that referenced
this pull request
Dec 11, 2019
juanpedromoreno
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See 47degrees/pbdirect#20
Because it is still a plain old sealed abstract class + case object hierarchy, this change will not affect Avro serialization using avro4s (confirmed with manual testing).
Note: This change assumes that enumeratum is on Mu's classpath, which is not yet true. PR to add it as a dependency.
Update: I've tested the whole
.proto-> src gen -> gRPC server flow manually using locally-published artifacts and confirmed that protobuf enumerations now work 🎉