-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work on docs #37
Work on docs #37
Conversation
Co-Authored-By: Flavio Corpa <flavio.corpa@47deg.com>
Co-Authored-By: Flavio Corpa <flavio.corpa@47deg.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome, every time we add new docs the usage becomes clearer and clearer (and the API also improves 😉), good job! 🙌
sayHello :: (MonadServer m, WithLog env String m) | ||
=> HelloRequest -> m HelloResponse | ||
sayHello (HelloRequest nm) = do | ||
logInfoN "running hi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to be logDebug
or something like that from the co-log
library? 🤔
Co-Authored-By: Flavio Corpa <flavio.corpa@47deg.com>
Co-Authored-By: Flavio Corpa <flavio.corpa@47deg.com>
Fixes #31
Fixes #36