Separate annotations from core schema type #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Travis failure is so weird. How can it fail in the PR but not in the branch? Furthermore, it seems completely non-reproducible in my machine, with either LTS or Nightly. |
|
Now I understand, the problem is that it's conflicting with the |
|
Apparently it didn't work 😖 |
|
I am fairly confident that now it should work. Please review and merge if it's green :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before definitions like the id for ProtoBuf were part of the schema. However, that meant that we could not retro-fit the same schema for different purposes. This PR separates these two concepts and updates the Template Haskell code, so examples don't need to change.
This change will be properly documented in #31