Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mixed bag of changes:
mypy
checking, but I thought this would be useful. Sphinx docs for public functions might also be good for this.split()
in a couple places, but then only grab the 0th, 1st, or -1th item. Doesn't make sense to check the whole string or start from the left in some cases. Tweaked this.isinstance
instead oftype() ==
in some places and cleaning some code that seemed repetitive.Feel free to critique. I'm happy to undo some changes if you feel I got too fancy etc.