-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation updates #1149
base: main
Are you sure you want to change the base?
Documentation updates #1149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small improvement suggestion, but a very good uplift, well done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the effort to review the documenation, @jknndy. Definitely worthwhile, looking at some of the mistakes you've found.
Co-authored-by: Michael Duffett <46545313+mlduff@users.noreply.github.com>
Perhaps a strange question: has anyone had experience of sitting with newcomers to While reading the changes I'm trying to get a sense for how the documentation -- particularly the in-depth scraper guide -- reads logically. So far it seems pretty good to me, but there's no substitute for feedback from people learning it for the first time. |
Co-authored-by: James Addison <55152140+jayaddison@users.noreply.github.com>
Not personally but this is exactly the reason I pinged @mlduff for a review at the start! I believe they started contributing to the library after the original docs were published which made their input useful here. We could open a discussion or issue inviting new developers to post about their experience with the docs / where they might have gotten stuck or thought things could be better outlined? Possibly including a link to the discussion at the top of each doc file & somewhere in the readme. |
@jknndy Can confirm I started contributing recently, reading through the docs initially. I found it fairly easy to understand, the page I frequented the most was the one detailing each of the scraper functions (and then Ctrl+F searching to see if websites were supported). |
@mlduff , were there any particular parts of the dev process that you thought the documentation was lacking? I agree that the scraper functionality page is our most expansive so maybe not but you never know! |
I'm having an awful time running the scraper on Windows via WSL with pip installed. I'm just trying to scrape all the HelloFresh URLs to import into Mealie. |
@jonzey231 please could you create a separate GitHub issue thread with details of the problem you're experiencing? Thank you! |
Re-reviewed all docs and made a ton of changes/corrections.
Appreciate any feedback!
@mlduff , mind taking a look?