Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow non-object array in body #674

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Conversation

mlankamp
Copy link
Contributor

fixes #673

Copy link

stackblitz bot commented Jun 13, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Jun 13, 2024

🦋 Changeset detected

Latest commit: 7aab7c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hey-api/client-fetch Patch
@example/openapi-ts-fetch Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 10:36am

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.67%. Comparing base (d937233) to head (7aab7c5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #674   +/-   ##
=======================================
  Coverage   75.67%   75.67%           
=======================================
  Files          74       74           
  Lines        7400     7400           
  Branches      692      692           
=======================================
  Hits         5600     5600           
  Misses       1797     1797           
  Partials        3        3           
Flag Coverage Δ
unittests 75.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey can you change it to patch please? Other than that looks good, thanks for the fix!

@mlankamp
Copy link
Contributor Author

Changed to patch

@mrlubos mrlubos merged commit a4eef0f into hey-api:main Jun 13, 2024
16 checks passed
@github-actions github-actions bot mentioned this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client-fetch: array of string in body unsupported
2 participants