Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): do not send default params #267

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Apr 5, 2024

Closes #202

Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2024 1:21am

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 13.63636% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 89.22%. Comparing base (9235d63) to head (0fce118).

❗ Current head 0fce118 differs from pull request most recent head 82f7619. Consider uploading reports for the commit 82f7619 to get more accurate results

Files Patch % Lines
packages/openapi-ts/src/utils/handlebars.ts 13.63% 38 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
- Coverage   90.05%   89.22%   -0.84%     
==========================================
  Files          65       65              
  Lines        4041     4082      +41     
  Branches      464      464              
==========================================
+ Hits         3639     3642       +3     
- Misses        401      439      +38     
  Partials        1        1              
Flag Coverage Δ
unittests 89.22% <13.63%> (-0.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos force-pushed the fix/client-remove-default-params branch from 0fce118 to 82f7619 Compare April 5, 2024 01:20
@mrlubos mrlubos marked this pull request as ready for review April 5, 2024 01:21
@mrlubos mrlubos merged commit b81dd9a into main Apr 5, 2024
14 checks passed
@mrlubos mrlubos deleted the fix/client-remove-default-params branch April 5, 2024 01:38
@github-actions github-actions bot mentioned this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not set default parameters in client
2 participants