Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): use only isRequired to determine if field is required #264

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Apr 4, 2024

No description provided.

Copy link

vercel bot commented Apr 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2024 0:32am

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 89.97%. Comparing base (1652111) to head (12b311f).

Files Patch % Lines
packages/openapi-ts/src/utils/handlebars.ts 40.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
- Coverage   90.08%   89.97%   -0.11%     
==========================================
  Files          65       65              
  Lines        4043     4049       +6     
  Branches      464      465       +1     
==========================================
+ Hits         3642     3643       +1     
- Misses        400      405       +5     
  Partials        1        1              
Flag Coverage Δ
unittests 89.97% <40.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos merged commit 32bb3a6 into main Apr 5, 2024
14 of 16 checks passed
@mrlubos mrlubos deleted the fix/model-default branch April 5, 2024 00:40
@github-actions github-actions bot mentioned this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants