Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): support all http error codes #188

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

jordanshatford
Copy link
Collaborator

ref: #152 (comment)

Support HTTP codes from MDN

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.84%. Comparing base (7558299) to head (86077b3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #188   +/-   ##
=======================================
  Coverage   91.84%   91.84%           
=======================================
  Files          66       66           
  Lines        3935     3935           
  Branches      476      476           
=======================================
  Hits         3614     3614           
  Misses        320      320           
  Partials        1        1           
Flag Coverage Δ
unittests 91.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice! Isn't there an easier way to support error handling than listing all though?

@jordanshatford
Copy link
Collaborator Author

This is nice! Isn't there an easier way to support error handling than listing all though?

Unfortunately I don't think. I took a look at how other projects do it. Axios for example has a similar way

@jordanshatford jordanshatford merged commit ca10eb6 into main Mar 30, 2024
14 checks passed
@jordanshatford jordanshatford deleted the feat/support-all-http-codes branch March 30, 2024 11:31
@github-actions github-actions bot mentioned this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants