Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): unify fetch and node clients #185

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

jordanshatford
Copy link
Collaborator

@jordanshatford jordanshatford commented Mar 30, 2024

NOTE: node-fetch was made to replicate the Fetch API, rather than duplicating all templates (as we plan to eventually move away from templates), I have combined them with flags in the only places that differ (import from node-fetch and credentials as node-fetch doesnt support those)

This will be also nice as node client is legacy, AND fetch will eventually be supported fully in node (21) and is already experimental since our lowest supported version (node 18)

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.84%. Comparing base (cefbda4) to head (80a5886).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
- Coverage   91.87%   91.84%   -0.03%     
==========================================
  Files          66       66              
  Lines        3949     3935      -14     
  Branches      476      476              
==========================================
- Hits         3628     3614      -14     
  Misses        320      320              
  Partials        1        1              
Flag Coverage Δ
unittests 91.84% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanshatford jordanshatford merged commit 7b66dfa into main Mar 30, 2024
14 checks passed
@jordanshatford jordanshatford deleted the feat/unify-node-and-fetch-templates branch March 30, 2024 04:04
@github-actions github-actions bot mentioned this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants