Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct relative path to bundled client when imported from nested module #1123

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Oct 5, 2024

Closes #1120

Copy link

stackblitz bot commented Oct 5, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Oct 5, 2024

🦋 Changeset detected

Latest commit: 032338c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2024 4:10pm

Copy link

codecov bot commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 40.67797% with 35 lines in your changes missing coverage. Please review.

Project coverage is 80.49%. Comparing base (d82ec1d) to head (032338c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/openapi-ts/src/generate/utils.ts 22.22% 21 Missing ⚠️
...napi-ts/src/plugins/@tanstack/query-core/plugin.ts 10.00% 9 Missing ⚠️
packages/openapi-ts/src/generate/client.ts 66.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1123      +/-   ##
==========================================
- Coverage   80.65%   80.49%   -0.17%     
==========================================
  Files         104      104              
  Lines       11663    11707      +44     
  Branches     1237     1238       +1     
==========================================
+ Hits         9407     9423      +16     
- Misses       2253     2281      +28     
  Partials        3        3              
Flag Coverage Δ
unittests 80.49% <40.67%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

pkg-pr-new bot commented Oct 5, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@hey-api/client-axios@1123
pnpm add https://pkg.pr.new/@hey-api/client-fetch@1123
pnpm add https://pkg.pr.new/@hey-api/openapi-ts@1123

commit: 032338c

@mrlubos mrlubos merged commit 4afe9bd into main Oct 5, 2024
15 of 17 checks passed
@mrlubos mrlubos deleted the fix/bundle-client-relative-path branch October 5, 2024 16:18
@github-actions github-actions bot mentioned this pull request Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When config.client.bundle is true, the import path for the client is incorrect in plugin.
1 participant