Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Go Modules #214

Closed
wants to merge 3 commits into from
Closed

Conversation

marwan-at-work
Copy link
Contributor

No description provided.

@slimsag
Copy link
Member

slimsag commented Sep 14, 2018

Looks like this is causing some failure on CI

@marwan-at-work
Copy link
Contributor Author

marwan-at-work commented Sep 14, 2018

@slimsag not sure what megacheck does but this is what's being returned:

1.68s$ megacheck -tags=js ./...
/home/travis/.gimme/versions/go1.11.linux.amd64/src/runtime/internal/sys/zgoos_linux.go:8:7: GOOS redeclared in this block
couldn't load packages due to errors: runtime, runtime/internal/sys

Sounds like a possible error in ignoring build tags. Does it make any sense to you?

@slimsag
Copy link
Member

slimsag commented Sep 15, 2018

megacheck is a very nice linter 😃

My guess is that megacheck is not playing well with go modules right now. It looks like there is an open issue and a separate next branch there for adding go modules support dominikh/go-tools#328

Probably we can try just checking out that next branch and seeing if that fixes the problem, otherwise we will have to temporarily disable megacheck which would be sad :/

@AnikHasibul
Copy link

Take a look at #220

@slimsag
Copy link
Member

slimsag commented Jan 20, 2019

Moved the blackfriday upgrade to #228 since PRs should be scoped to one singular change.

@slimsag slimsag mentioned this pull request Jan 20, 2019
@slimsag
Copy link
Member

slimsag commented Jan 20, 2019

Fixed conflicts + remaining issues and opened new PR #229

(I retained your authorship information so you still get credit, of course 😄)

@slimsag slimsag closed this Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants