Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ineffective poll interval option #822

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

jooola
Copy link
Member

@jooola jooola commented Jul 23, 2024

The hcloud client option name was using the retry back off option instead of the poll back off option.

@jooola jooola requested a review from a team as a code owner July 23, 2024 14:21
@jooola jooola changed the title fix: wrong client option name for poll backoff func fix: invalid use of poll interval option Jul 23, 2024
@jooola jooola changed the title fix: invalid use of poll interval option fix: ineffective poll interval option Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.58%. Comparing base (64aa9ce) to head (90fd82c).

Files Patch % Lines
internal/state/state.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #822   +/-   ##
=======================================
  Coverage   59.58%   59.58%           
=======================================
  Files         209      209           
  Lines        7693     7693           
=======================================
  Hits         4584     4584           
  Misses       2458     2458           
  Partials      651      651           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola jooola requested a review from apricote July 23, 2024 14:26
@jooola jooola merged commit 41aaa56 into main Jul 23, 2024
5 checks passed
@jooola jooola deleted the fix-poll-backoff-option branch July 23, 2024 14:44
apricote added a commit that referenced this pull request Jul 25, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.46.0](v1.45.0...v1.46.0)
(2024-07-25)


### Features

* **load-balancer-type:** show traffic details for each location in
describe output
([5c9380c](5c9380c))
* **server-type:** show traffic details for each location in describe
output
([5c9380c](5c9380c))


### Bug Fixes

* ineffective poll interval option
([#822](#822))
([41aaa56](41aaa56))
* printing for server create with mulitple networks
([#824](#824))
([f3fcbd2](f3fcbd2))
* **server-type:** remove deprecated traffic column
([5c9380c](5c9380c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Julian Tölle <julian.toelle@hetzner-cloud.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant