Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build an export file in CI, too #858

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Build an export file in CI, too #858

merged 1 commit into from
Feb 28, 2019

Conversation

joshwlewis
Copy link
Member

@joshwlewis joshwlewis commented Feb 27, 2019

Without an export file, subsequent testpacks can't use Ruby.

This example repo will not compile on CI or pass tests when using the heroku/ruby buildpack. The example repo expects bundle and ruby to be available on the $PATH during the node buildpack bin/test-compile and bin/test stages. With this change, the example repo builds and passes tests on CI.

@schneems schneems merged commit 423da10 into heroku:master Feb 28, 2019
@schneems
Copy link
Contributor

schneems commented Mar 7, 2019

This has been deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants