Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Heroku-16 #1163

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Remove support for Heroku-16 #1163

merged 1 commit into from
Jun 2, 2021

Conversation

edmorley
Copy link
Member

@edmorley edmorley commented Jun 1, 2021

The Heroku-16 stack reached end-of-life on May 1st, 2021, and from June 1st, 2021, builds were disabled:
https://help.heroku.com/0S5P41DC/heroku-16-end-of-life-faq

This change:

  • Removes Heroku-16 + Cedar-14 from the Ruby version presence check.
  • Removes the now unused libyaml vendoring step, since it only ran on Heroku-16 and Cedar-14.
  • Makes the buildpack release process no longer vendor the Heroku-16 Ruby archive.

Refs GUS-W-9329723.

@edmorley edmorley self-assigned this Jun 1, 2021
The Heroku-16 stack reached end-of-life on May 1st, 2021, and from
June 1st, 2021, builds were disabled:
https://help.heroku.com/0S5P41DC/heroku-16-end-of-life-faq

This change:
* Removes Heroku-16 + Cedar-14 from the Ruby version presence check.
* Removes the now unused `libyaml` vendoring step, since it only ran
  on Heroku-16 and Cedar-14.
* Makes the buildpack release process no longer vendor the Heroku-16
  Ruby archive.

Refs GUS-W-9329723.
edmorley added a commit to heroku/docker-heroku-ruby-builder that referenced this pull request Jun 1, 2021
Since they are all end-of-life and no longer supported by the Heroku
build system.

See also:
heroku/heroku-buildpack-ruby#1163

Refs GUS-W-9329723.
@edmorley edmorley marked this pull request as ready for review June 1, 2021 09:31
@edmorley edmorley requested a review from a team as a code owner June 1, 2021 09:31
@edmorley edmorley requested a review from schneems June 1, 2021 09:32
Copy link
Contributor

@schneems schneems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@schneems schneems merged commit 52e02d5 into main Jun 2, 2021
@schneems schneems deleted the edmorley/rm-heroku-16 branch June 2, 2021 18:52
schneems pushed a commit to heroku/docker-heroku-ruby-builder that referenced this pull request Jun 7, 2021
Since they are all end-of-life and no longer supported by the Heroku
build system.

See also:
heroku/heroku-buildpack-ruby#1163

Refs GUS-W-9329723.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants