Use jvm buildpack to install JRuby dependencies #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/use-jvm-buildpack-directly
branch
5 times, most recently
from
cb4b959
to
ed6c07e
Compare
|
@schneems Is this ready for review? The reviewers feature has requested review from the languages team due to codeowners, but it seems that the CI is being iterated on for the moment. Any objection to converting this PR to a draft, to make the "doesn't need review yet" state clearer? :-) Just since I open a PR to review as soon as I see this email notification :-)
|
schneems
force-pushed
the
schneems/use-jvm-buildpack-directly
branch
4 times, most recently
from
a0f81b7
to
9020a1a
Compare
schneems
force-pushed
the
schneems/use-jvm-buildpack-directly
branch
8 times, most recently
from
4cd1f1d
to
591279d
Compare
|
This is now ready for review. Also It's got a rebase from the fixes in #1122 |
Currently the jvm logic is duplicated in this buildpack and the jvm buildpack. By using the JVM buildpack we can reduce duplication and increase consistency across the Heroku platform.
schneems
force-pushed
the
schneems/use-jvm-buildpack-directly
branch
from
591279d
to
9073127
Compare
Previously the function compile_buildpack_v2 directly uses $1, $2, and $3. This change updates this function to instead use named local variables. In addition, there was a typo in the output to the user.
edmorley
approved these changes
Feb 9, 2021
krisrang
added a commit
to skyltmax/heroku-buildpack-ruby
that referenced
this pull request
May 13, 2021
* upstream/main: (52 commits) Fix date (heroku#1152) Bundler 2.2.16 (heroku#1150) v226 (heroku#1149) [changelog skip] Remove Heroku-16 from tests: (heroku#1146) [close 1135] Update bundler 2.x to 2.2.15 (heroku#1144) [changelog skip] Clean up mime magic in repos (heroku#1145) Clean up CNB release process (heroku#1139) Use correct method name in script heroku#1129 (heroku#1129) Post-release updates: heroku/ruby 0.1.0 (heroku#1138) Add package.toml (heroku#1137) Add CNB release scripts (heroku#1136) Release v225 (heroku#1133) [close heroku#1126] Update bundler to 2.2.11 (heroku#1132) Update buildpack tests (heroku#1131) v224 (heroku#1128) Use jvm buildpack to install JRuby dependencies (heroku#1119) Fix YAML formatting (heroku#1116) Rails 2, 3, and 4 LTS tests (heroku#1115) v223 (heroku#1114) Fail detection with a CNB-friendly exit code (heroku#1112) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the jvm logic is duplicated in this buildpack and the jvm buildpack. By using the JVM buildpack we can reduce duplication and increase consistency across the Heroku platform.