[close #818] Disable spring #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/disable-spring
branch
from
6b9bcbb
to
b13c9da
Compare
edmorley
approved these changes
Jun 10, 2020
schneems
force-pushed
the
schneems/disable-spring
branch
from
b13c9da
to
e0719e3
Compare
Spring causes erratic and unpredictable failures, most recently in ticket https://heroku.support/881089. We can avoid these class of problems entirely by disabling the library. Any benefits that spring provide come from repeatedly calling the same command, for example spring would speed up running `rails test` twice. However most commands on Heroku are only run once (`rails server` on boot for example) so using spring on the system would provide little to no realized practical benefit. I feel so strongly about the need to disable spring that I do not want to provide an "escape valve" to disable the behavior of disabling spring.
schneems
force-pushed
the
schneems/disable-spring
branch
from
e0719e3
to
be4855b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring causes erratic and unpredictable failures, most recently in ticket https://heroku.support/881089. We can avoid these class of problems entirely by disabling the library.
Any benefits that spring provide come from repeatedly calling the same command, for example spring would speed up running
rails testtwice. However most commands on Heroku are only run once (rails serveron boot for example) so using spring on the system would provide little to no realized practical benefit.I feel so strongly about the need to disable spring that I do not want to provide an "escape valve" to disable the behavior of disabling spring.