Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uhyve Interface V2 #754

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Uhyve Interface V2 #754

wants to merge 3 commits into from

Conversation

jounathaen
Copy link
Member

The old uhyve interface is based on the outb instruction (on x86_64). This creates issues, when the physical memory of the guest is beyond the 32-Bit boundary, as the outb instruction only accepts 32-bit parameters.

I think the best approach is to move to MMIO based hypercalls instead (as also suggested in the KVM docu). Drawback: They are slower than IO based hypercalls.

Whilst on it, I redefined the hypercall interface and added the definition for possible future hypercalls.

Summary:

This is a non-breaking change, as the old hypercall interface can still be implemented in uhhve. However, Currently, the memory where the hypercalls are mapped is mapped as regular memory. However, this will be changed in #725
The old interface can be marked deprecated and be removed in future versions.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 4.87805% with 39 lines in your changes missing coverage. Please review.

Project coverage is 66.82%. Comparing base (f407069) to head (10bf5b3).

Files with missing lines Patch % Lines
uhyve-interface/src/v2/mod.rs 0.00% 22 Missing ⚠️
uhyve-interface/src/v1/mod.rs 5.55% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #754      +/-   ##
==========================================
- Coverage   67.45%   66.82%   -0.63%     
==========================================
  Files          20       21       +1     
  Lines        2338     2360      +22     
==========================================
  Hits         1577     1577              
- Misses        761      783      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jounathaen jounathaen force-pushed the uhyve_if_v2 branch 2 times, most recently from 5935d37 to a77400e Compare September 19, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant