Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: virtio-net implementation in uhyve #536

Closed
wants to merge 74 commits into from
Closed

Draft: virtio-net implementation in uhyve #536

wants to merge 74 commits into from

Conversation

BaderSZ
Copy link

@BaderSZ BaderSZ commented Jul 7, 2023

This a somewhat-functional implementation for virtio-net. I'll follow up with comments, tests and likely a few examples for RustyHermit soon.

Github also hates my rebasing, so I'll have to fix that.

dependabot bot and others added 30 commits May 25, 2023 11:37
@dependabot @BaderSZ
Bump vmm-sys-util from 0.10.0 to 0.11.0
967969b 
Bumps [vmm-sys-util](https://github.com/rust-vmm/vmm-sys-util) from 0.10.0 to 0.11.0.
- [Release notes](https://github.com/rust-vmm/vmm-sys-util/releases)
- [Changelog](https://github.com/rust-vmm/vmm-sys-util/blob/main/CHANGELOG.md)
- [Commits](rust-vmm/vmm-sys-util@v0.10.0...v0.11.0)

---
updated-dependencies:
- dependency-name: vmm-sys-util
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @BaderSZ
Bump vmm-sys-util from 0.11.0 to 0.11.1
1cb1a55 
Bumps [vmm-sys-util](https://github.com/rust-vmm/vmm-sys-util) from 0.11.0 to 0.11.1.
- [Release notes](https://github.com/rust-vmm/vmm-sys-util/releases)
- [Changelog](https://github.com/rust-vmm/vmm-sys-util/blob/main/CHANGELOG.md)
- [Commits](rust-vmm/vmm-sys-util@v0.11.0...v0.11.1)

---
updated-dependencies:
- dependency-name: vmm-sys-util
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @BaderSZ
Bump virtio-bindings from 0.1.0 to 0.2.0
35aca59 
Bumps [virtio-bindings](https://github.com/rust-vmm/vm-virtio) from 0.1.0 to 0.2.0.
- [Release notes](https://github.com/rust-vmm/vm-virtio/releases)
- [Commits](rust-vmm/vm-virtio@virtio-queue-v0.1.0...virtio-bindings-v0.2.0)

---
updated-dependencies:
- dependency-name: virtio-bindings
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@BaderSZ
Rebase
7dc3be0
@BaderSZ
Correct old comments
b3b1d7f
@BaderSZ
Derive default for VirtIO capabilities collector
bcf9d12
@BaderSZ
Remove unused return value for send_packets
516dd72
@BaderSZ
Update and correct comments
0f6e689
@BaderSZ
ADd type annotation to CPU count argument
bf7ac96
@BaderSZ
Implement struct for virtio feature selector
c14b109
@BaderSZ
Add and track VM/Virtqueue crates
958c2af
@BaderSZ
Use vm_memory crate for guest allocation
ed5f455
@BaderSZ
Move and track guest memory in virtio
3c99b5c
@BaderSZ
Make virtqueue align public
8322a66
@BaderSZ
Use virtio queue crate instead of in-house
3a56e4a
@BaderSZ
Set feature selector during virtio initialization
631ff94
@BaderSZ
Enable notifications after reception handling
96badba
@BaderSZ
Disable trace logs in packet transmission, collapse ifs
eb63b61
@BaderSZ
Implement a ComCap queue reset method
0eaf9bd
@BaderSZ
Disable trace log after sending frames
4c2f576
@BaderSZ
Remove outdated comments
ff65d99
@BaderSZ
Replace frame number with bool value
75f9764
@dependabot @BaderSZ
Bump criterion from 0.4.0 to 0.5.1
8f83373 
Bumps [criterion](https://github.com/bheisler/criterion.rs) from 0.4.0 to 0.5.1.
- [Changelog](https://github.com/bheisler/criterion.rs/blob/master/CHANGELOG.md)
- [Commits](bheisler/criterion.rs@0.4.0...0.5.1)

---
updated-dependencies:
- dependency-name: criterion
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @BaderSZ
Bump log from 0.4.17 to 0.4.18
983db7c 
Bumps [log](https://github.com/rust-lang/log) from 0.4.17 to 0.4.18.
- [Release notes](https://github.com/rust-lang/log/releases)
- [Changelog](https://github.com/rust-lang/log/blob/master/CHANGELOG.md)
- [Commits](rust-lang/log@0.4.17...0.4.18)

---
updated-dependencies:
- dependency-name: log
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @BaderSZ
Bump mac_address from 1.1.4 to 1.1.5
764a23e 
Bumps [mac_address](https://github.com/rep-nop/mac_address) from 1.1.4 to 1.1.5.
- [Commits](https://github.com/rep-nop/mac_address/commits)

---
updated-dependencies:
- dependency-name: mac_address
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@jounathaen @BaderSZ
Moved hypercall related consts and fns out into a separate crate
b11c0f7
@jounathaen @BaderSZ
Added an enum containing the hypercalls and the ports
e14c4fb
@jounathaen @BaderSZ
use num-derive to easily convert u16 into HypercallPorts
f162e20
@jounathaen @BaderSZ
Hypercall enum includes references instead of copies of the parameters
16d40a0
@jounathaen @BaderSZ
Improved documentation of the hypercall interface
4698fe2
dependabot bot and others added 20 commits July 7, 2023 09:51
@dependabot @BaderSZ
Bump libc from 0.2.145 to 0.2.146
35fcfa9 
Bumps [libc](https://github.com/rust-lang/libc) from 0.2.145 to 0.2.146.
- [Release notes](https://github.com/rust-lang/libc/releases)
- [Commits](rust-lang/libc@0.2.145...0.2.146)

---
updated-dependencies:
- dependency-name: libc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @BaderSZ
Bump time from 0.3.21 to 0.3.22
6f4ad59 
Bumps [time](https://github.com/time-rs/time) from 0.3.21 to 0.3.22.
- [Release notes](https://github.com/time-rs/time/releases)
- [Changelog](https://github.com/time-rs/time/blob/main/CHANGELOG.md)
- [Commits](time-rs/time@v0.3.21...v0.3.22)

---
updated-dependencies:
- dependency-name: time
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @BaderSZ
Bump clap from 4.3.1 to 4.3.3
a9b969a 
Bumps [clap](https://github.com/clap-rs/clap) from 4.3.1 to 4.3.3.
- [Release notes](https://github.com/clap-rs/clap/releases)
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md)
- [Commits](clap-rs/clap@clap_complete-v4.3.1...v4.3.3)

---
updated-dependencies:
- dependency-name: clap
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @BaderSZ
Bump log from 0.4.18 to 0.4.19
04d28c4 
Bumps [log](https://github.com/rust-lang/log) from 0.4.18 to 0.4.19.
- [Release notes](https://github.com/rust-lang/log/releases)
- [Changelog](https://github.com/rust-lang/log/blob/master/CHANGELOG.md)
- [Commits](rust-lang/log@0.4.18...0.4.19)

---
updated-dependencies:
- dependency-name: log
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @BaderSZ
Bump bitflags from 2.3.1 to 2.3.2
f9ae670 
Bumps [bitflags](https://github.com/bitflags/bitflags) from 2.3.1 to 2.3.2.
- [Release notes](https://github.com/bitflags/bitflags/releases)
- [Changelog](https://github.com/bitflags/bitflags/blob/main/CHANGELOG.md)
- [Commits](bitflags/bitflags@2.3.1...2.3.2)

---
updated-dependencies:
- dependency-name: bitflags
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @BaderSZ
Bump clap from 4.3.3 to 4.3.4
ac8b972 
Bumps [clap](https://github.com/clap-rs/clap) from 4.3.3 to 4.3.4.
- [Release notes](https://github.com/clap-rs/clap/releases)
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md)
- [Commits](clap-rs/clap@v4.3.3...v4.3.4)

---
updated-dependencies:
- dependency-name: clap
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @BaderSZ
Bump clap from 4.3.3 to 4.3.4
da8a072 
Bumps [clap](https://github.com/clap-rs/clap) from 4.3.3 to 4.3.4.
- [Release notes](https://github.com/clap-rs/clap/releases)
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md)
- [Commits](clap-rs/clap@v4.3.3...v4.3.4)

---
updated-dependencies:
- dependency-name: clap
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@jounathaen @BaderSZ
Bumped hermit-sys to 0.5
ab8adca
@jounathaen @BaderSZ
Removed old disfunctional and unused networking code. A new implement…
e043aaf 
…ation is in progress
@dependabot @BaderSZ
Bump libc from 0.2.146 to 0.2.147
b226ddc 
Bumps [libc](https://github.com/rust-lang/libc) from 0.2.146 to 0.2.147.
- [Release notes](https://github.com/rust-lang/libc/releases)
- [Commits](rust-lang/libc@0.2.146...0.2.147)

---
updated-dependencies:
- dependency-name: libc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @BaderSZ
Bump hermit-entry from 0.9.3 to 0.9.4
98e6187 
Bumps [hermit-entry](https://github.com/hermitcore/hermit-entry) from 0.9.3 to 0.9.4.
- [Release notes](https://github.com/hermitcore/hermit-entry/releases)
- [Commits](hermit-os/hermit-entry@v0.9.3...v0.9.4)

---
updated-dependencies:
- dependency-name: hermit-entry
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @BaderSZ
Bump clap from 4.3.4 to 4.3.8
758c35a 
Bumps [clap](https://github.com/clap-rs/clap) from 4.3.4 to 4.3.8.
- [Release notes](https://github.com/clap-rs/clap/releases)
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md)
- [Commits](clap-rs/clap@v4.3.4...v4.3.8)

---
updated-dependencies:
- dependency-name: clap
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@jounathaen @mkroening @BaderSZ
Improved memory size checking. Check for multiple of hugepagesize
502d0b8 
Co-authored-by: Martin Kröning <mkroening@posteo.net>
@dependabot @BaderSZ
Bump clap from 4.3.8 to 4.3.10
4829def 
Bumps [clap](https://github.com/clap-rs/clap) from 4.3.8 to 4.3.10.
- [Release notes](https://github.com/clap-rs/clap/releases)
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md)
- [Commits](clap-rs/clap@v4.3.8...v4.3.10)

---
updated-dependencies:
- dependency-name: clap
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @BaderSZ
Bump bitflags from 2.3.2 to 2.3.3
5691108 
Bumps [bitflags](https://github.com/bitflags/bitflags) from 2.3.2 to 2.3.3.
- [Release notes](https://github.com/bitflags/bitflags/releases)
- [Changelog](https://github.com/bitflags/bitflags/blob/main/CHANGELOG.md)
- [Commits](bitflags/bitflags@2.3.2...2.3.3)

---
updated-dependencies:
- dependency-name: bitflags
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@BaderSZ
Rebase
01c462d
@BaderSZ
Add and track VM/Virtqueue crates
09641cf
@BaderSZ
Fix rebase additional argument errors
ea5452f
@BaderSZ
Remove legacy match cases reintroduced in rebase
17143e2
@BaderSZ
Remove outdated imports from rebase
111a12b
@jounathaen
Copy link
Member

Shall I fix the rebase, or will you do that?

dependabot bot and others added 4 commits July 11, 2023 17:44
@dependabot @BaderSZ
Bump vmm-sys-util from 0.10.0 to 0.11.0
f5c3dea 
Bumps [vmm-sys-util](https://github.com/rust-vmm/vmm-sys-util) from 0.10.0 to 0.11.0.
- [Release notes](https://github.com/rust-vmm/vmm-sys-util/releases)
- [Changelog](https://github.com/rust-vmm/vmm-sys-util/blob/main/CHANGELOG.md)
- [Commits](rust-vmm/vmm-sys-util@v0.10.0...v0.11.0)

---
updated-dependencies:
- dependency-name: vmm-sys-util
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @BaderSZ
Bump vmm-sys-util from 0.11.0 to 0.11.1
ec4cf63 
Bumps [vmm-sys-util](https://github.com/rust-vmm/vmm-sys-util) from 0.11.0 to 0.11.1.
- [Release notes](https://github.com/rust-vmm/vmm-sys-util/releases)
- [Changelog](https://github.com/rust-vmm/vmm-sys-util/blob/main/CHANGELOG.md)
- [Commits](rust-vmm/vmm-sys-util@v0.11.0...v0.11.1)

---
updated-dependencies:
- dependency-name: vmm-sys-util
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @BaderSZ
Bump virtio-bindings from 0.1.0 to 0.2.0
4731d5f 
Bumps [virtio-bindings](https://github.com/rust-vmm/vm-virtio) from 0.1.0 to 0.2.0.
- [Release notes](https://github.com/rust-vmm/vm-virtio/releases)
- [Commits](rust-vmm/vm-virtio@virtio-queue-v0.1.0...virtio-bindings-v0.2.0)

---
updated-dependencies:
- dependency-name: virtio-bindings
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@BaderSZ
Merge branch 'master' into virtio-net
11c0b0f
@BaderSZ
Copy link
Author

BaderSZ commented Jul 11, 2023

Shall I fix the rebase, or will you do that?

Should be rebased now.

@jounathaen jounathaen mentioned this pull request Feb 19, 2024
Draft
@jounathaen
Copy link
Member

I close this in favor of #643

@jounathaen jounathaen closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BaderSZ @jounathaen