Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not throw on sparse data layers. #496

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Not throw on sparse data layers. #496

merged 1 commit into from
Dec 21, 2021

Conversation

OleksiiZubko
Copy link
Collaborator

@OleksiiZubko OleksiiZubko commented Dec 13, 2021

The issue is about throwing an error by SDK in case of
an empty QuadTreeIndex response.

SDK returns 204 response with this fix.

Resolves: OLPSUP-16894

Signed-off-by: Oleksii Zubko ext-oleksii.zubko@here.com

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #496 (eee6a32) into master (f3f336c) will increase coverage by 0.5420%.
The diff coverage is 100.0000%.

Impacted file tree graph

@@               Coverage Diff                @@
##             master       #496        +/-   ##
================================================
+ Coverage   88.9567%   89.4987%   +0.5421%     
================================================
  Files            82         82                
  Lines          2952       2952                
  Branches        329        329                
================================================
+ Hits           2626       2642        +16     
+ Misses          178        155        -23     
- Partials        148        155         +7     
Impacted Files Coverage Δ
...here/olp-sdk-dataservice-read/lib/utils/getTile.ts 40.7408% <100.0000%> (+27.7778%) ⬆️
...ice-read/lib/cache/QuadTreeIndexCacheRepository.ts 25.0000% <0.0000%> (+12.5000%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3f336c...eee6a32. Read the comment docs.

Copy link
Collaborator

@andescu andescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, but the commit message does not. Please explain the issue and the solution.

The issue is about throwing an error by SDK in case of
an empty QuadTreeIndex response.

SDK returns 204 response with this fix.

Resolves: OLPSUP-16894

Signed-off-by: Oleksii Zubko <ext-oleksii.zubko@here.com>
@OleksiiZubko OleksiiZubko merged commit 467c73e into master Dec 21, 2021
@OleksiiZubko OleksiiZubko deleted the OLPSUP-16894-fix branch December 21, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants