Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecates. #485

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Remove deprecates. #485

merged 1 commit into from
Aug 13, 2021

Conversation

OleksiiZubko
Copy link
Collaborator

Remove old deprecated code with ending
deprecation period 6 months.

Resolves: OLPEDGE-2620

Signed-off-by: Oleksii Zubko ext-oleksii.zubko@here.com

@OleksiiZubko OleksiiZubko force-pushed the remove_deprecates branch 2 times, most recently from 3ff4227 to c35420d Compare August 12, 2021 10:00
Remove old deprecated code with ending
deprecation period 6 months.

Resolves: OLPEDGE-2620

Signed-off-by: Oleksii Zubko <ext-oleksii.zubko@here.com>
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #485 (b088662) into master (22e1c06) will decrease coverage by 0.0233%.
The diff coverage is 100.0000%.

❗ Current head b088662 differs from pull request most recent head 0bfc9f2. Consider uploading reports for the commit 0bfc9f2 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##             master       #485        +/-   ##
================================================
- Coverage   88.8629%   88.8396%   -0.0232%     
================================================
  Files            83         82         -1     
  Lines          2990       2930        -60     
  Branches        339        324        -15     
================================================
- Hits           2657       2603        -54     
  Misses          181        181                
+ Partials        152        146         -6     
Impacted Files Coverage Δ
@here/olp-sdk-authentication/lib/UserAuth.ts 83.6364% <ø> (ø)
@here/olp-sdk-dataservice-api/lib/blob-api.ts 88.5058% <ø> (+0.7195%) ⬆️
...aservice-read/lib/cache/MetadataCacheRepository.ts 83.3334% <ø> (-1.6666%) ⬇️
...k-dataservice-read/lib/client/PartitionsRequest.ts 100.0000% <ø> (ø)
...olp-sdk-dataservice-read/lib/client/QueryClient.ts 72.2223% <100.0000%> (-0.9920%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22e1c06...0bfc9f2. Read the comment docs.

@OleksiiZubko OleksiiZubko merged commit 4ca51ff into master Aug 13, 2021
@OleksiiZubko OleksiiZubko deleted the remove_deprecates branch August 13, 2021 10:48
ystefinko pushed a commit that referenced this pull request Aug 18, 2021
Remove old deprecated code with ending
deprecation period 6 months.

Resolves: OLPEDGE-2620

Signed-off-by: Oleksii Zubko <ext-oleksii.zubko@here.com>
@mykhailo-kuchma mykhailo-kuchma mentioned this pull request Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants