Github Actions pipeline instead of Travis #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgarvardt
force-pushed
the
feature/github-actions-pipeline
branch
from
8cb0c3e
to
164decb
Compare
vgarvardt
force-pushed
the
feature/github-actions-pipeline
branch
from
1cca48f
to
eb2f836
Compare
vgarvardt
commented
Aug 24, 2021
| @@ -66,10 +66,6 @@ func TestIDFromString(t *testing.T) { | |||
| "some string", | |||
| "some string", | |||
| }, | |||
| { | |||
| "UUID with missing minuses", | |||
| "f4ec75dbc0b04b00a04fa0d9ed18e9fb", | |||
There was a problem hiding this comment.
updated UUID library handles this case, so it is not invalid anymore
lucasmdrs
reviewed
Aug 25, 2021
lucasmdrs
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small maintenance for this project - use GH Actions as CI and bump min go version and deps.