Feature/like button code conventions

[plahteenlahti]

Description

Provide new bookmarking functionality for lessons, weeks and habits. Based on work made by Kayla on branch #6. I have refactored the data fetching logic so that it's easier to understand, and fixed type errors and race conditions.

Type of change

• Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Test A
• Test B

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[plahteenlahti]

? I don't understand why this is done

[turq84]

I think it's pointless too, but eslint was making a big deal about re-using the same "FOOTER.SUPPORT" multiple times. Said to assign it to a variable and use that instead. Threw an error because of it. I can undo it or add a line for eslint to by pass it.

[plahteenlahti]

This should be unnecessary. The returned weeks array contains objects already have the value whether they've bookmarked or not

[plahteenlahti]

Also, you're defining the bookmarked value outside the map, which means that it will always reassign as the loop runs. It should also be constant like const bookmarked = bookmarkeSearch ? true : false, instead of reassigned variable. But just remove this because it should not be needed.

[turq84]

In your opinion, what's the best approach to show the bookmarked content on the cards (week/lesson). We have two data sets. The weeks array and the bookmarkedData array. I took the inner loop away, so it's just the weeks array getting mapped. I'm just wondering what you think is the best way.

<Weeks>
          {weeks.map((week: ContentfulWeek) => {
            return (
              <WeekCard
                bookmarked={false}
                key={`${week?.slug}`}
                path={`/week/${week?.slug}`}
                intro={week?.intro}
                name={week?.weekName}
                duration={week?.duration}
                lessons={week?.lessons}
                coverPhoto={week?.coverPhoto?.fluid as FluidObject}
                slug={week.slug}
              />
            )
          })}
        </Weeks>