-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable PL debug mode, increasing power threshold for active channel #301
Disable PL debug mode, increasing power threshold for active channel #301
Conversation
Regarding you question: I read the setting "Upper power limit:" in the DPL settings like this: "Never make the inverter output more than this amount of power." Then it makes sense to scale the power limit beyond this setting, as we expect to scale the power limit such that the actual AC output power matches the "Upper power limit:" value. However, see my comment on enabling the whole scaling logic in point 2 above. |
6533dd4
to
4cefe0d
Compare
Thanks for spotting the issue on 3. that was what I meant. I did fix this in the code but I probably overwrote this change. I agree that the debug messages are very helpful. I also liked the status printouts that you implemented... Kudos! |
Thanks 😊 I was looking at this again (coming from #300) and noticed that you only guard the message with |
Yeah I agree. I'll update that this evening |
@MalteSchm let me know when this PR is ready to merge |
4cefe0d
to
32bb5e3
Compare
@helgeerbe I'm done & ready to merge |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Smaller PR that:
Rationale:
The PL was recently changed to no longer run in a 10s interval. This causes the debug printouts to be printed way more often. I believe this has lead to stability issues highlighted here Stability issues with development branch #298
This PR disables the printouts for now which is kind of a hotfix
My Inverter reports a power of 0.9W on a single channel when idle. The other channels indicate about 1.5W. This triggers the producing channels detection code and will scale a requested limit by a factor of 1.3 when starting up. This PR increases the detection threshold to 2W.
When no active channels are detected the limit is not checked against the maximum inverter power. This PR makes this a mandatory check
Issues / Questions
Right now setNewPowerLimit enforces the maximum configured limit before the producing channel detection / scaling. This seems like a bug to me as the user would expect a UI configured value to be used.
Am I right here or is this intensional?