-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPL: Honor battery-provided discharge power limit (including UI adjustments) #1245
DPL: Honor battery-provided discharge power limit (including UI adjustments) #1245
Conversation
Add discharge current limit as a input field with the option to use the battery reported limit as well. (All battery providers including mqtt)
One question after a first glance: |
Good catch @spcqike, i need to update the hint text. Whatever limit is lower will be used
|
Screenshots updated |
… for mqtt battery
We will now also show a live view for MQTT batteries when the discharge current limit is present. |
0fc6f37
to
ff39f2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicking to annoy you 😉
ff39f2a
to
4a837f3
Compare
35d74e5
to
750dc67
Compare
3566f28
to
599b460
Compare
Github did not manage to detect that the first commit is merely already on development. I had to rebase manually. This set me as the committer, which I don't like and wasn't my intention. After a quick Internet search it seems this is tedious to avoid... |
Dont worry about having my name on a commit.. its alright. after a rebase we will be both mentioned in the commit, thats fine for me |
Based on the great work from @ranma!
Base: #1198
Additions