extended ZEN_EXPECT while logging x value #34
Conversation
Added bool to check for the expression to be true or false
|
I have named the function as to_string i think its causing an error if ok then i will change the name of that function then commit and also inform me about the arguments as i have passed one more in ZEN_EXPECT to log the value of x. |
I was passing two arguments so the error occurred in test case. I removed it without changing the actual context. Also renamed the function
|
Sorry for the inconvenience. Can you please again review the changes i have committed in this branch only |
|
@Sudhanva21 Thanks for your efforts. Your changes break the build. Please follow the instructions in on how to build & test locally on your machine and first ensure that your local build succeeds and passes all tests. Also, follow the issue #33 description more closely; for example, the ZEN_EXPECT macro has to stay backward-compatible (it currently accepts one argument - any expression - and that has to stay the same). Also, you've introduced to_string, which is unnecessary since STL already has it as |
|
Sure, Sir. Sorry for the inconvenience. I will first try to pass all the test cases locally and then commit the final changes to this branch. |
|
@Sudhanva21 No worries at all and thank you for your efforts. I'd advise not to try to be fast on any new project, but careful and correct first. And it's okay if it takes multiple iterations & discussions. |
…e-logging-x-value' into alpha.h/extended-ZEN_EXPECT-while-logging-x-value
|
Hey..This time i have build and run on my local machine and all the test cases passed. Pls review it |
Extended ZEN_EXPECT with helper macros fro various types of comparison and also logs the value of x when the test case fails.