Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hardhat erc721 #2

Merged
merged 4 commits into from
Feb 9, 2024
Merged

feat: hardhat erc721 #2

merged 4 commits into from
Feb 9, 2024

Conversation

bguiz
Copy link
Member

@bguiz bguiz commented Jan 30, 2024

What

  • Add a new hardhat project
  • Imports ERC721 implementation from OZ

Why

  • Demo use of non-fungible tokens using a pure HSCS implementation (no HTS)
  • Demo use of deployment to Hedera Testnet + verification via Sourcify

@bguiz bguiz mentioned this pull request Jan 30, 2024
Merged
2 tasks
@a-ridley a-ridley self-requested a review February 6, 2024 18:59
a-ridley
a-ridley requested changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@a-ridley a-ridley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a bit more guidance on what is needed to get this running upfront will help.

In addition, lets try to figure out why npx mnemonics is giving that issue or how to work around it :)

@a-ridley a-ridley self-requested a review February 9, 2024 02:08
a-ridley
a-ridley approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@a-ridley a-ridley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

love that you add a clean command and description of error and what to do :)

@bguiz bguiz merged commit 51bd36f into main Feb 9, 2024
@bguiz bguiz deleted the feat/hardhat-erc721 branch February 9, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-ridley a-ridley a-ridley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bguiz @a-ridley