-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SASS syntax correctly #5
Comments
And I found this issue is somehow related to #4. |
But can't you just write
and everything's happy-go-lucky? |
There is no special handling for this in vue-loader. The Related lines: |
And you have tried: { test: /.scss$/, loader: "style!css!sass" }, as I suggested on #4? |
AH, ok I see. So no abstraction there - that's just for file name ending. Ok… |
Please check how they handle it in the sublime package then and we'll do the same? |
Too bad if we can't support old sass simutanously though…? |
Can we do the same they have: |
Or does that mean that they just threw away old sass highlighting and mapped both scss and sass to sass? |
Yeah. I think we should just throw away the old sass highlighting (sass) and mapped both scss and sass to scss (not sass)? |
The problem has existed for a loong time, and not well been handled by |
Please consider PR for mapping both to scss then and I'll release right On Thu, Nov 5, 2015 at 10:31 AM Aidi Stan notifications@github.com wrote:
|
Finally I manage to find a way to fix this by adding following lines in module.exports = {
// ...
vue: {
loaders: {
scss: 'style!css!sass'
}
}
}; Now we can support both sass and scss simutanously in this way. I suggest to add a notice for this common pitfall:
|
Cool! I'll add to readme and close. |
Just FYI,
|
@laander Thxs. |
@laander your way is not useful for me, I have to add style-loader in this vue-loader version |
How would a solution for a nuxt project look like? Nuxt is taking care of the webpack config, and I am not sure what is the correct way to extend it. |
There are two syntaxes available for Sass. The new one, known as SCSS (Sassy CSS) and recommanded by Sass, is an extension of the syntax of CSS and more widely used today. And the sass loader for Webpack, sass-loader, only processes
.scss
files as described in its document.Thus we have to write styles like this in
.vue
fileswhich should be highlighted in SCSS syntax, not in SASS syntax.
It's a little weird. So I open this issue for discussion instead of sending a PR to correct directly.
The text was updated successfully, but these errors were encountered: