-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests and fix some issues #14
Conversation
There 2 issues have been addressed: - If the given g:pydocstring_templates_dir is not ended with a slash '/', auto append it. - Reduce the need for one local variable (s:tmpldir) since we always have to use one variable to store template dir.
Perhaps you also want to enable Travis CI integration, since we now have tests. 😄 |
Wow! awsome!! Thank you so much!! Could you add |
I tried integrate with Travis, and fail due to wrong indentation. The tests work just fine with both nvim (0.2.0-dev) and vim (7.4) on my machine (Ubuntu 16.10). But not on Travis (Vim 7.3). I also tried to installl and use nvim on Travis. Still no luck. I don't know why. 😞 To be honest, this is the first time I try vader. Perhaps, we could skip this integration for later, and focus on #13. |
@letientai299 I try to run your PR at my local Mac(running macOSX 10.11.6 and MacVim 8.0).
What should I do? I think I miss something 😢 |
I think you have not enable Pydocstring on
|
fi | ||
|
||
# Open vim with readonly mode just to execute all *.vader tests. | ||
$VIM_EXE -Nu minimal_vimrc -R "+Vader $1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need !
run Vim and exec Vader
command.
-$VIM_EXE -Nu minimal_vimrc -R "+Vader $1"
+$VIM_EXE -Nu minimal_vimrc -R "+Vader! $1"
fi | ||
|
||
# Open vim with readonly mode just to execute all *.vader tests. | ||
$VIM_EXE -Nu minimal_vimrc -R '+Vader *.vader' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-$VIM_EXE -Nu minimal_vimrc -R '+Vader *.vader'
+$VIM_EXE -Nu minimal_vimrc -R '+Vader! *.vader'
@letientai299 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks ok to me. But I don't know how to merge your change into this PR.
@letientai299 Thank you so much to adding test! |
@letientai299 I fixed |
Wow, so the trick is build vim itself to get the latest version. |
This is my fisrt step to address #13.
This includes:
I also fix 2 issues:
g:pydocstring_templates_dir
if needed.s:tmpldir
to save some memory.