After feature for TOTP to prevent code reuse #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 19, 2022
| totp.verify(code, drift_behind: drift) | ||
| else | ||
| totp.verify(code) | ||
| otp_after = public_send(otp_after_column_name) if otp_after_column_name_enabled? |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [88/80]
thiagogabriel
force-pushed
the
feature-after-otp
branch
from
50c25e6
to
6bb7f1f
Compare
|
👍 |
TylerRick
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful to be able to prevent the code reuse on OTP, specially when sending the code via SMS, which requires the extension of the time the code will be valid by using
drift.ROTP reference:
https://github.com/mdp/rotp/blob/2be11551ac4982670d526ceef4a5db985d0f626a/README.md#preventing-reuse-of-time-based-otps