Add support for ruby 3.0 #77
Conversation
| assert_match %r{^otpauth://totp/Example\:roberto@heapsource\.com\?secret=\w{32}&issuer=Example$}, @user.provisioning_uri(nil, issuer: "Example") | ||
| assert_match %r{^otpauth://totp/Example\:roberto@heapsource\.com\?secret=\w{32}&issuer=Example$}, @visitor.provisioning_uri(nil, issuer: "Example") | ||
| assert_match %r{^otpauth://totp/Example\:roberto%40heapsource\.com\?secret=\w{32}&issuer=Example$}, @user.provisioning_uri(nil, issuer: "Example") | ||
| assert_match %r{^otpauth://totp/Example\:roberto%40heapsource\.com\?secret=\w{32}&issuer=Example$}, @visitor.provisioning_uri(nil, issuer: "Example") |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [153/80]
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| assert_match %r{^otpauth://hotp/\?secret=\w{32}&counter=0$}, @member.provisioning_uri | ||
| end | ||
|
|
||
| def test_provisioning_uri_with_options | ||
| assert_match %r{^otpauth://totp/Example\:roberto@heapsource\.com\?secret=\w{32}&issuer=Example$}, @user.provisioning_uri(nil, issuer: "Example") | ||
| assert_match %r{^otpauth://totp/Example\:roberto@heapsource\.com\?secret=\w{32}&issuer=Example$}, @visitor.provisioning_uri(nil, issuer: "Example") | ||
| assert_match %r{^otpauth://totp/Example\:roberto%40heapsource\.com\?secret=\w{32}&issuer=Example$}, @user.provisioning_uri(nil, issuer: "Example") |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [150/80]
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| assert_match %r{^otpauth://totp/roberto@heapsource\.com\?secret=\w{32}$}, @user.provisioning_uri | ||
| assert_match %r{^otpauth://totp/roberto@heapsource\.com\?secret=\w{32}$}, @visitor.provisioning_uri | ||
| assert_match %r{^otpauth://totp/roberto%40heapsource\.com\?secret=\w{32}$}, @user.provisioning_uri | ||
| assert_match %r{^otpauth://totp/roberto%40heapsource\.com\?secret=\w{32}$}, @visitor.provisioning_uri |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [105/80]
| @@ -91,14 +91,14 @@ def test_provisioning_uri_with_provided_account | |||
| end | |||
|
|
|||
| def test_provisioning_uri_with_email_field | |||
| assert_match %r{^otpauth://totp/roberto@heapsource\.com\?secret=\w{32}$}, @user.provisioning_uri | |||
| assert_match %r{^otpauth://totp/roberto@heapsource\.com\?secret=\w{32}$}, @visitor.provisioning_uri | |||
| assert_match %r{^otpauth://totp/roberto%40heapsource\.com\?secret=\w{32}$}, @user.provisioning_uri | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [102/80]
|
I'm using this branch for a Rails 6.1 / Ruby 3.0 app. So far, so good. Would love to see this merged! |
|
Any news about it? 🤝 |
|
pinging: @robertomiranda 👍 |
|
@robertomiranda When you have time, could you please release a official version with Ruby 3 support? Today, we are using a fork with this PR inside it, but is better a oficial release 😄 🤝 |
Updated
rotpwith ruby 3.0 support, made small fix inactive_model_otp, to support ruby 3.0