Adding options to provisioning uri, so we can include issuer #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertomiranda
added a commit
that referenced
this pull request
Nov 18, 2014
Adding options to provisioning uri, so we can include issuer
|
@doon thanks 👍 |
|
This is awesome, glad this was added! Could this be added to the Readme though? Took quiet a bit of googleing to find this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just adds an the ability to pass an options hash to provisioning_uri, so we can add the issuer key, and pass it upstream to ROTP.. Allows us to Add the text at The top in Google Authenticator..