Fix iterating using only a timestamp column #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the cursor is created with only one time column, decoding it would crash, reporting that the columns and values have different sizes. This is because `Array(values)` attempts to call `#to_ary` and `#to_a` on its arguments before manually wrapping it in an array. This means that `Time#to_a` is called, which returns an array of 10 elements.
fatkodima
force-pushed
the
allow-single-time-column-cursors
branch
from
503ce51
to
9a4699d
Compare
fatkodima
changed the title
scottmatthewman
commented
May 13, 2024
| @@ -48,8 +48,8 @@ def deserialize_time_if_needed(value) | |||
| attr_reader :columns, :values | |||
|
|
|||
| def initialize(columns:, values:) | |||
| @columns = Array(columns) | |||
| @values = Array(values) | |||
| @columns = Array.wrap(columns) | |||
There was a problem hiding this comment.
Oh, that's even neater! Thanks
There was a problem hiding this comment.
Thanks for the fix! ❤️ I will merge this and release a new version later today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the cursor is created with only one time column, decoding it would crash, reporting that the columns and values have different sizes.
This is because
Array(values)attempts to call#to_aryand#to_aon its arguments before manually wrapping it in an array. This means thatTime#to_ais called, which returns an array of 10 elements.The remedy is to do that manual wrapping ourselves, so that we can ensure that the values are always wrapped in an array, and then call
flattenso that if an array was passed in, it is unwrapped back into a single level array.Fixes #4