Merge pull request #1305 from hcoles/bug/too_much_sun

Non jdk classes picked up by filter
hcoles · Feb 3, 2024 · 608a7e5 · 608a7e5
2 parents c6e250c + 9d503f6
commit 608a7e5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/pitest/src/main/java/org/pitest/coverage/execute/CoverageOptions.java b/pitest/src/main/java/org/pitest/coverage/execute/CoverageOptions.java
@@ -64,8 +64,8 @@ private static Predicate<String> commonClasses() {
             glob("org.pitest.*"),
             glob("java.*"),
             glob("javax.*"),
-            glob("com.sun*"),
-            glob("org.junit*"),
+            glob("com.sun.*"),
+            glob("org.junit.*"),
             glob("sun.*"));
   }
 

diff --git a/pitest/src/test/java/org/pitest/coverage/execute/CoverageOptionsTest.java b/pitest/src/test/java/org/pitest/coverage/execute/CoverageOptionsTest.java
@@ -39,9 +39,19 @@ public void shouldNotCoverSunClassesWhenFilterIsBroad() {
     assertThat(this.testee.getFilter().test("sun.foo.Bar")).isFalse();
   }
 
+  @Test
+  public void shouldNotCoverDotSun() {
+    assertThat(this.testee.getFilter().test("com.sun.dance")).isFalse();
+  }
+
+  @Test
+  public void shouldCoverSunDance() {
+    assertThat(this.testee.getFilter().test("com.sundance")).isTrue();
+  }
+
   @Test
   public void shouldNotCoverJUnitWhenFilterIsBroad() {
-    assertThat(this.testee.getFilter().test("sun.foo.Bar")).isFalse();
+    assertThat(this.testee.getFilter().test("org.junit.Bar")).isFalse();
   }
 
   @Test